swiftlang / swift-installer-scripts

Apache License 2.0
67 stars 34 forks source link

Changelog #276

Closed LightYagami28 closed 6 months ago

LightYagami28 commented 6 months ago

Changelog

πŸš€ Features:

πŸ“ Directory Structure:

πŸ“ Documentation:

πŸ” Testing:

🌐 Localization:

πŸ™Œ Contributors:

πŸ“… Date:

🚦 CI/CD:

🚧 Known Issues:

πŸ“Œ Dependencies:

πŸ“„ Documentation Updates:

compnerd commented 6 months ago

Please split this up into smaller chunks that can be reviewed, the changes as is are overwhelming

The majority of the WiX changes seem questionable to me. As a concrete example, the replacement of amp; with & is incorrect, that has semantic differences. The comments being removed were useful as they explained why somethings were done and what to do if making changes. Please provide pointers to the documentation that motivate those changes as the structuring currently is based upon the recommendation from FireGiant, the authors of the WiX packaging system.

LightYagami28 commented 6 months ago

Ok i fix then i made a new pr separate