search

swiftlang / swift-installer-scripts

Apache License 2.0
73 stars 38 forks source link

WiX: correct the install conditions #329

Closed compnerd closed 3 months ago

compnerd commented 3 months ago

This is a surprising interaction between variable types. Variables set at the command line are set as string types. The variables in the bundle are numeric (either 1 or 0 to match the semantics of check boxes). The original install condition (InstallCondition="OptionsInstall.*" would evaluate the condition as a string, where any value would evaluate as true. To force a comparison, where Burn will coerce values more like expectations, perform an explicit equality check.

compnerd commented 3 months ago

Tested at https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/5422/ ; ran the installer locally and verified that .\installer.exe /quiet OptionsInstallIde=0 did not install sourcekit-lsp.exe.