search

swiftlang / swift-llbuild

A low-level build system, used by Xcode and the Swift Package Manager
Apache License 2.0
1.09k stars 199 forks source link

Add missing dependency declarations to package manifest #950

Closed ahoppen closed 1 week ago

ahoppen commented 3 weeks ago

This makes llbuild build with swift build --explicit-target-dependency-import-check error.

ahoppen commented 3 weeks ago

@swift-ci Please test

ahoppen commented 2 weeks ago

@swift-ci Please test Windows

ahoppen commented 2 weeks ago

@swift-ci Please test Linux

ahoppen commented 2 weeks ago

@swift-ci Please smoke test

ahoppen commented 2 weeks ago

@swift-ci Please test Windows

ahoppen commented 2 weeks ago

@swift-ci Please test

owenv commented 2 weeks ago

SwiftPM is incorrectly flagging this as a missing dependency since it's unable to parse clang module maps to determine those module names with 100% accuracy. https://github.com/swiftlang/swift-llbuild/pull/891 and linked PRs have some context where this change broke builds last time it was made

ahoppen commented 2 weeks ago

Is there an issue tracking this incorrectly flagged issue on the SwiftPM side?