swiftlang / swift-org-website

Swift.org website
https://swift.org
Other
460 stars 173 forks source link

Modernize visual appearance of grids #742

Open rauhul opened 1 week ago

rauhul commented 1 week ago

Updates all grids except for package grids to take a more layered appearance matching that of the tabs.

Adds support for "prefers-contrast: more" to use the previous higher contrast style.

Removes the many grid css styles and replaces them with a common grid style in the elements folder than can be reused between pages.

Builds on top of #743, #749, and #751

rauhul commented 1 week ago

@swift-ci test

rauhul commented 1 week ago
older screenshots # Before & After ## Home Screenshot 2024-06-25 at 1 56 19 PM Screenshot 2024-06-25 at 1 57 56 PM ## Getting Started Screenshot 2024-06-25 at 1 56 30 PM Screenshot 2024-06-25 at 1 58 03 PM ## Packages Screenshot 2024-06-25 at 1 58 26 PM Screenshot 2024-06-25 at 1 58 13 PM ## Tools Screenshot 2024-06-25 at 1 58 39 PM Screenshot 2024-06-25 at 1 58 46 PM
heckj commented 1 week ago

For my part, it lowers the reading contrast in those grey-blocked sections a bit too much. No qualms about the added visual structure blocking things out, but I'd at least toss in a request for a darker font/weighting to get the contrast back up.

rauhul commented 1 week ago

For my part, it lowers the reading contrast in those grey-blocked sections a bit too much. No qualms about the added visual structure blocking things out, but I'd at least toss in a request for a darker font/weighting to get the contrast back up.

For both dark and light mode or just one specifically?

heckj commented 1 week ago

Ah, sorry - really just the light mode. The difference in the dark mode didn't my eyes as hard - it's a little reduced, but not to a level that makes reading more difficult for me. I'll never complain about a bit more contrast though ;-)

dempseyatgithub commented 1 week ago

Since the existing style is very high contrast, we should consider preserving it as a prefers-contrast CSS media query for accessibility users requiring high contrast. I don't think that has been a concern before with the existing style.

dempseyatgithub commented 1 week ago

I find the use of the orange color for call outs, for example the "Get Involved" section of the package page to draw far too much attention to that element. Getting involved is important, which is why it is in a call out box, but it is not the most important thing on the page.

I find the orange color draws the eye too much for these kind of call outs.

Changing the link text and underline from blue to orange also make the link / call to action in the call out much less visible. Scanning the original, it is clear the box wants people to get involved with the main way of getting involved as 'Nominate packages'.

Using the orange color for the call to action about the migration guide on the home page is meant to draw the eye, especially on a home page where the content is largely static, and where directing visitors to the migration guide is an important and transient announcement.

rauhul commented 1 week ago

@dempseyatgithub I pulled the banner changes out into #749, could you take a look there?

rauhul commented 6 days ago

Before & After

Home
Light - Default Screenshot 2024-06-28 at 3 33 05 PM
Light - Increased Contrast Screenshot 2024-06-28 at 3 33 12 PM
Dark - Default Screenshot 2024-06-28 at 3 33 31 PM
Dark - Increased Contrast Screenshot 2024-06-28 at 3 33 38 PM
Packages
Light - Default Screenshot 2024-06-28 at 3 40 58 PM
Light - Increased Contrast Screenshot 2024-06-28 at 3 41 01 PM
Dark - Default Screenshot 2024-06-28 at 3 41 13 PM
Dark - Increased Contrast Screenshot 2024-06-28 at 3 41 17 PM
Install
Light - Default Screenshot 2024-06-28 at 3 34 16 PM
Light - Increased Contrast Screenshot 2024-06-28 at 3 34 19 PM
Dark - Default Screenshot 2024-06-28 at 3 34 02 PM
Dark - Increased Contrast Screenshot 2024-06-28 at 3 34 06 PM
kubamracek commented 4 days ago

Large +1 from me, this is a big improvement.