swiftlang / swift-org-website

Swift.org website
https://swift.org
Other
477 stars 188 forks source link

Fix duplicated grays #743

Closed rauhul closed 3 months ago

rauhul commented 5 months ago

Removes figure-gray-secondary-alt in favor of figure-gray-tertiary which already had the exact same color values.

Fixes fill-quaternary to have different colors in dark and light mode.

rauhul commented 5 months ago

@swift-ci test

rauhul commented 5 months ago

Note: there is no observable affect of this change on the website visually

rauhul commented 5 months ago

What's the policy on merging this PR, since moving to the swiftlang org I do not seem to be able to merge it myself.

federicobucchi commented 5 months ago

I am waiting for another approval from someone from the working group: https://www.swift.org/website-workgroup/

rauhul commented 5 months ago

Gotcha, is that the general policy? if so would it make sense to require PRs to have 2 approvals?

federicobucchi commented 5 months ago

It is hard to enforce pragmatically specific rules because there are specific people depending on the page and the type of change. Sometimes we need approval from someone in PR (which is included also in the WG). Sometimes 1 approval is enough because the change was discussed / approved in forums.swift.org. So difficult to set a specific unique rule.

alexandersandberg commented 5 months ago

Personally, I think it's better to wait with these smaller improvements/refactors (unless they provide value enough that we don't want to wait with it) until we get a chance to revisit the whole color palette—something we (the website workgroup) want to look into soon.

kaishin commented 3 months ago

@swift-ci test

rauhul commented 3 months ago

@kaishin could we merge this one too?