search

swiftlang / swift-org-website

Swift.org website
https://swift.org
Other
477 stars 188 forks source link

Reduce duplicated code for banners #749

Closed rauhul closed 3 months ago

rauhul commented 5 months ago

Unifies the banner and cta css styles used on multiple pages.

Moves the element to a common location so the it can be found in the source easily and be reused across pages.

rauhul commented 5 months ago

@swift-ci test

dempseyatgithub commented 5 months ago

Do the cherry-picks in this PR include turning the banners on all the pages orange?

rauhul commented 5 months ago

@dempseyatgithub nope, I split out the orange into a subclass(?) called ".banner.primary" which is only used on the home page right now.

kaishin commented 3 months ago

@rauhul Feel free to merge.

rauhul commented 3 months ago

@kaishin unfortunately I cannot merge because I lost "write" and "push" access to this repo after the move to "swiftlang".

@swiftlang/contributor-experience how can I regain access?

xedin commented 3 months ago

@rauhul I think you want to reach out to the website workgroup on forums.

rauhul commented 3 months ago

@rauhul I think you want to reach out to the website workgroup on forums.

Thanks I started a forum group dm!

kaishin commented 3 months ago

Sorry @rauhul I wasn't aware. I will take care of merging in the meantime then 👍