search

swiftlang / swift-package-manager

The Package Manager for the Swift Programming Language
Apache License 2.0
9.71k stars 1.34k forks source link

[SR-7828] Include name-based "fixits" whenever we do a unique name membership lookup #4803

Open aciidgh opened 6 years ago

aciidgh commented 6 years ago
Previous ID SR-7828
Radar rdar://problem/34911728
Original Reporter @aciidb0mb3r
Type Bug
Status Reopened
Resolution
Additional Detail from JIRA | | | |------------------|-----------------| |Votes | 0 | |Component/s | Package Manager | |Labels | Bug, StarterBug | |Assignee | None | |Priority | Medium | md5: 09bf5631fee7a0af06fa651808d31d64

Issue Description:

This diagnostic is not very good, SwiftPM should suggest the right spelling by comparing against the products which are available and suggesting a likely match if the string edit distance is small enough, similar to what the compiler does.

$ swift build
error: product dependency 'FooBar' not found

The edit distance algorithm as landed in SwiftPM with https://github.com/apple/swift-package-manager/pull/1431

swift-ci commented 6 years ago

Comment by Jhonny Bill Mena (JIRA)

https://github.com/apple/swift-package-manager/pull/1747

mininny commented 1 year ago

This can now be closd. @MaxDesiatov Could you kindly close this please?

MaxDesiatov commented 1 year ago

IMO, the resolution is incomplete, as the PR in question only added warnings, while this issue requested actual fix-its that users can easily apply by clicking on them, like with any other fix-it.