search

swiftlang / swift-package-manager

The Package Manager for the Swift Programming Language
Apache License 2.0
9.65k stars 1.31k forks source link

Remove unused `Codable` conformances on `PackageModel` types #7687

Closed MaxDesiatov closed 1 week ago

MaxDesiatov commented 1 week ago

The conformances are unused and pull in an additional TSCUtility.PolymorphicCodableProtocol dependency. This change removes about 0.2-0.4 MB from final executables on macOS when comparing with swift build -c release to main.

Also allows us to rename these types more easily to disambiguate between host/target triples and manifest targets/modules in our code.

If there's an existing user of this JSON manifest serialization we're unaware of, they should rely on swift package describe --type json instead, which has stable, consistent, and tested output.

MaxDesiatov commented 1 week ago

@swift-ci test

MaxDesiatov commented 1 week ago

@swift-ci test

MaxDesiatov commented 1 week ago

@swift-ci test windows