search

swiftlang / swift-package-manager

The Package Manager for the Swift Programming Language
Apache License 2.0
9.75k stars 1.35k forks source link

Improve displayVersion and scmRevision description exposed by PluginContextSerializer #7934

Closed dfed closed 1 month ago

dfed commented 2 months ago

Avoid using String(describing:) to create strings that can be utilized by consumers.

Motivation:

Version and revision strings with Optional(...) in them look less-than-great

Modifications:

Utilized thing?.description ?? "nil" rather than String(describing: thing).

Result:

Improved the readability of displayVersion and scmRevision in a Package's origin: PackagePlugin.PackageOrigin.

MaxDesiatov commented 2 months ago

@swift-ci test

dschaefer2 commented 2 months ago

@swift-ci test

dschaefer2 commented 2 months ago

@swift-ci test windows

dfed commented 2 months ago

Anything I can do to get windows tests passing?

xedin commented 2 months ago

@swift-ci please test Windows platform

xedin commented 1 month ago

@swift-ci please test

xedin commented 1 month ago

@swift-ci please clean test

xedin commented 1 month ago

@swift-ci please test

xedin commented 1 month ago

@swift-ci please test Windows platform