Make AsyncHTTPClient optional dependency

kateinoigakukun commented 5 months ago

Add a new abstraction HTTPClientProtocol to abstract the HTTP client operations.
Add a new OfflineHTTPClient type that just throws an error when trying to download a file.
Remove httpClient member from Engine and pass the HTTP client as a parameter to the queries that need it.
Separate Query and CacheKey protocols to allow for queries having properties that are not part of the cache key.

kateinoigakukun commented 5 months ago

@swift-ci test

kateinoigakukun commented 5 months ago

@swift-ci test macOS

kateinoigakukun commented 5 months ago

@swift-ci test macOS

kateinoigakukun commented 5 months ago

@swift-ci test

kateinoigakukun commented 5 months ago

Hmm testCanDealWithRunawayChildProcesses seems very flaky now.


Looking up configuration values...
2024-04-08T11:35:51+0000 debug x : arguments=["-c", "set -e\n/usr/bin/yes \"Runaway process from testCanDealWithRunawayChildProcesses(), please file a swift-sdk-generator bug.\" > /dev/null &\nchild_pid=$!\ntrap \"echo >&2 killing $child_pid; kill -KILL $child_pid\" INT\necho \"$child_pid\" # communicate the child pid to our parent\nexec >&- # close stdout\necho \"waiting for $child_pid\" >&2\nwait"] executable=/bin/bash pid=80314 [AsyncProcess] running command
2024-04-08T11:35:51+0000 debug x : pid=80314 [AsyncProcess] we got cancelled
2024-04-08T11:35:51+0000 trace x : pid=80314 step=sendSignal(2, allowedTimeNS: 10000000000) [AsyncProcess] running teardown sequence
2024-04-08T11:35:51+0000 debug x : arguments=["-c", "set -e\n/usr/bin/yes \"Runaway process from testCanDealWithRunawayChildProcesses(), please file a swift-sdk-generator bug.\" > /dev/null &\nchild_pid=$!\ntrap \"echo >&2 killing $child_pid; kill -KILL $child_pid\" INT\necho \"$child_pid\" # communicate the child pid to our parent\nexec >&- # close stdout\necho \"waiting for $child_pid\" >&2\nwait"] executable=/bin/bash pid=80314 termination-reason=exit termination-status=130 [AsyncProcess] finished running command
2024-04-08T11:35:51+0000 debug x : outcome=processHasExited pid=80314 step=sendSignal(2, allowedTimeNS: 10000000000) [AsyncProcess] teardown sequence step complete
/Users/ec2-user/jenkins/workspace/pr-swift-sdk-generator-macos/branch-main/swift-sdk-generator/Tests/AsyncProcessTests/IntegrationTests.swift:1075: error: -[AsyncProcessTests.IntegrationTests testCanDealWithRunawayChildProcesses] : XCTAssertEqual failed: ("-1") is not equal to ("0")
/Users/ec2-user/jenkins/workspace/pr-swift-sdk-generator-macos/branch-main/swift-sdk-generator/Tests/AsyncProcessTests/IntegrationTests.swift:1076: error: -[AsyncProcessTests.IntegrationTests testCanDealWithRunawayChildProcesses] : XCTAssertEqual failed: ("3") is not equal to ("9")
Test Case '-[AsyncProcessTests.IntegrationTests testCanDealWithRunawayChildProcesses]' failed (0.747 seconds).

kateinoigakukun commented 5 months ago

@swift-ci test macOS

swiftlang / swift-sdk-generator

Make AsyncHTTPClient optional dependency #101