search

swiftlang / swift-sdk-generator

Generate Swift SDKs for cross-compilation
Apache License 2.0
182 stars 15 forks source link

Fix 5.8 compatibility #118

Closed kateinoigakukun closed 3 months ago

kateinoigakukun commented 3 months ago

We still use 5.8 as a bootstrap compiler on CI, and https://github.com/swiftlang/swift-sdk-generator/pull/117 broke the compatibility with 5.8 by introducing use of new syntaxes introduced after 5.9. https://ci.swift.org/job/oss-swift-pr-test-crosscompile-wasm-ubuntu-20_04/1313/console

/home/build-user/swift-sdk-generator/Sources/Helpers/Vendor/Triple.swift:694:32: error: expected initial value after '='
      let arch: Triple.Arch? = switch (endianness, ISA) {
                               ^

See 2476ba715581ea1e7b6ed24011b6a34d0a6bab31 98c77bdfc7add7f05cc66079cfe8f65dd08ca790 for the main change of this PR. Other changes are just reverting #117 and re-applying swiftformat.

kateinoigakukun commented 3 months ago

@swift-ci test

kateinoigakukun commented 3 months ago

@swift-ci test macOS

MaxDesiatov commented 3 months ago

cc @zaneenders