search

swiftlang / swift-syntax

A set of Swift libraries for parsing, inspecting, generating, and transforming Swift source code.
Apache License 2.0
3.22k stars 410 forks source link

Expand trailing comma implementation #2689

Closed mateusrodriguesxyz closed 1 month ago

mateusrodriguesxyz commented 3 months ago

This continues the work that I began in https://github.com/apple/swift-syntax/pull/2515#event-12563352688. After feedback from the language steering group I have expanded the original proposal to allow trailing comma in more places. See the updated proposal text in https://github.com/swiftlang/swift-evolution/pull/2344.

mateusrodriguesxyz commented 1 month ago

@ahoppen I've updated the PR to match https://github.com/swiftlang/swift/pull/74522.

ahoppen commented 1 month ago

@swift-ci Please test

mateusrodriguesxyz commented 1 month ago

@ahoppen Don't you prefer that I squash the commits before merging? I went ahead and squashed the commits to stop the auto-merge as a precaution. Sorry for stopping the CI.

ahoppen commented 1 month ago

@swift-ci Please test

ahoppen commented 1 month ago

@swift-ci Please test Windows

ahoppen commented 1 month ago

Could you run swift-format on your changes?

ahoppen commented 1 month ago

@swift-ci Please test

ahoppen commented 1 month ago

@swift-ci Please test