Closed antigluten closed 6 days ago
This is awesome!
Can you also add some tests to make sure this doesn't suggest the refactor:
var x: Int {
get { 5 }
set { /*anything */ }
}
And that the refactor succeeds with:
var x: Int {
get { 5 }
}
@harlanhaskins Thank you, for your test suggestion!
@ahoppen, Thanks for your review, refactoring is done, added checking for get
accessor when we converting to the function
@swift-ci Please test
@swift-ci Please test Windows
Instead of merging main
into your branch, could you rebase your branch on top of the latest main
? It makes for a nicer git history and it’s too easy to hide weird subtle changes in merge commits.
@ahoppen, thank you for your hint, done rebasing
Accidentally removed the wrong branch
@swift-ci Please test
@swift-ci Please test Windows
A part of https://github.com/swiftlang/sourcekit-lsp/issues/1246