[SR-1240] Fix layering violations in libSwiftAST

[belkadan]

Previous ID	SR-1240
Radar	None
Original Reporter	@belkadan
Type	Task

Additional Detail from JIRA

| | | |------------------|-----------------| |Votes | 0 | |Component/s | Compiler | |Labels | Task | |Assignee | None | |Priority | Medium | md5: 7ed35162c69fb040a8f74bdbba0acce4

Issue Description:

The AST library references several symbols from other libraries:

• swift::checkMemberType(swift::DeclContext&, swift::Type, llvm::ArrayRef<swift::Identifier>), referenced from:

  • Swift::ArchetypeSelfTransformer::checkMemberTypeInternal(llvm::StringRef) in libswiftAST.a(ASTPrinter.o)

  • __ZNK5swift24ArchetypeSelfTransformer1FMUlNS_4TypeEE_clES1_ in libswiftAST.a(ASTPrinter.o)

• swift::isConvertibleTo(swift::Type, swift::Type, swift::DeclContext&), referenced from:

  • Swift::SynthesizedExtensionAnalyzer::Implementation::isApplicable(swift::ExtensionDecl*, bool) in libswiftAST.a(ASTPrinter.o)

• swift::canPossiblyEqual(swift::Type, swift::Type, swift::DeclContext&), referenced from:

  • Swift::SynthesizedExtensionAnalyzer::Implementation::isApplicable(swift::ExtensionDecl*, bool) in libswiftAST.a(ASTPrinter.o)

• swift::isExtensionApplied(swift::DeclContext&, swift::Type, swift::ExtensionDecl const*), referenced from:

  • Swift::ASTPrinter::printTypeInterface(swift::Type, swift::DeclContext*, llvm::raw_ostream&)::$_0::operator()(swift::ExtensionDecl const*) const in libswiftAST.a(ASTPrinter.o)

  • DoGlobalExtensionLookup(swift::Type, swift::Type, llvm::SmallVectorImpl<swift::ValueDecl*>&, swift::DeclContext const*, (anonymous namespace)::LookupState, swift::DeclVisibilityKind, swift::LazyResolver*) in libswiftAST.a(LookupVisibleDecls.o)

• swift::resolveValueMember(swift::DeclContext&, swift::Type, swift::DeclName), referenced from:

  • ShouldPrintAsFavorable(swift::Decl const*, swift::PrintOptions&) in libswiftAST.a(ASTPrinter.o)

  • Swift::SynthesizedExtensionAnalyzer::Implementation::isMemberFavored(swift::NominalTypeDecl const*, swift::Decl const*) in libswiftAST.a(ASTPrinter.o)

• swift::lookUpTypeInContext(swift::DeclContext*, llvm::StringRef), referenced from:

  • Swift::SynthesizedExtensionAnalyzer::Implementation::isApplicable(swift::ExtensionDecl*, bool) in libswiftAST.a(ASTPrinter.o)

  • Swift::SynthesizedExtensionAnalyzer::Implementation::checkElementType(llvm::StringRef) in libswiftAST.a(ASTPrinter.o)

• swift::canPossiblyConvertTo(swift::Type, swift::Type, swift::DeclContext&), referenced from:

  • Swift::SynthesizedExtensionAnalyzer::Implementation::isApplicable(swift::ExtensionDecl*, bool) in libswiftAST.a(ASTPrinter.o)

• swift::Lexer::initSubLexer(swift::Lexer&, swift::Lexer::State, swift::Lexer::State), referenced from:

  • Swift::Lexer::Lexer(swift::LangOptions const&, swift::SourceManager const&, unsigned int, swift::DiagnosticEngine*, bool, swift::CommentRetentionMode, unsigned int, unsigned int) in libswiftAST.a(RawComment.o)

• swift::Lexer::getLocForEndOfToken(swift::SourceManager const&, swift::SourceLoc), referenced from:

  • ToCharSourceRange(swift::SourceManager&, swift::SourceRange) in libswiftAST.a(DiagnosticEngine.o)

  • Swift::InFlightDiagnostic::fixItInsertAfter(swift::SourceLoc, llvm::StringRef) in libswiftAST.a(DiagnosticEngine.o)

  • Swift::Lexer::getCharSourceRangeFromSourceRange(swift::SourceManager const&, swift::SourceRange const&) in libswiftAST.a(ASTPrinter.o)

• swift::Lexer::lexImpl(), referenced from:

  • Swift::Lexer::lex(swift::Token&) in libswiftAST.a(RawComment.o)

• swift::Lexer::Lexer(swift::LangOptions const&, swift::SourceManager const&, swift::DiagnosticEngine*, unsigned int, bool, swift::CommentRetentionMode), referenced from:

  • Swift::Lexer::Lexer(swift::LangOptions const&, swift::SourceManager const&, unsigned int, swift::DiagnosticEngine*, bool, swift::CommentRetentionMode, unsigned int, unsigned int) in libswiftAST.a(RawComment.o)

• swift::isEqual(swift::Type, swift::Type, swift::DeclContext&), referenced from:

  • Swift::SynthesizedExtensionAnalyzer::Implementation::isApplicable(swift::ExtensionDecl*, bool) in libswiftAST.a(ASTPrinter.o)

For the Lexer ones, we should probably sink the Lexer into libSwiftBasic, or break it out into its own library. For the others, we should see if we can sink them into libSwiftAST, or failing that if we can lift the calling functions up to wherever the missing symbols are.

Note: to reproduce this list, edit the CMakeLists.txt file in unittest/AST/ to only link swiftAST.

[Dante-Broggi]

Is this resolved, or no longer valid? If either, this should be closed.

[belkadan]

Unresolved. :-(