search

swiftlang / swift

The Swift Programming Language
https://swift.org
Apache License 2.0
67.56k stars 10.35k forks source link

[SR-8234] [Source Compat] Some SwiftPM projects fail with: error: manifest parse error #50766

Closed clackary closed 5 years ago

clackary commented 6 years ago
Previous ID SR-8234
Radar rdar://42051065
Original Reporter @clackary
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA | | | |------------------|-----------------| |Votes | 0 | |Component/s | Project Infrastructure | |Labels | Bug | |Assignee | @clackary | |Priority | Medium | md5: 903da7e17885a3bc1db10df11a78e3ed

relates to:

Issue Description:

Failure logs:

https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/2113/artifact/swift-source-compat-suite/

03:05:03 ======================================== 
03:05:03 Failures: 
03:05:03 FAIL: BeaconKit, 4.0.3, 189b40, Swift Package 
03:05:03 FAIL: BeaconKit, 4.0, 189b40, Swift Package 
03:05:03 FAIL: BeaconKit, 3.1, 189b40, Swift Package 
03:05:03 FAIL: Deferred, 4.0, 190f44, Swift Package 
03:05:03 FAIL: Deferred, 3.2, 190f44, Swift Package 
03:05:03 FAIL: GRDB.swift, 4.0, f121c6, Swift Package 
03:05:03 FAIL: Lark, 4.0, 7604f9, Swift Package 
03:05:03 FAIL: Lark, 3.0, 017928, Swift Package 
03:05:03 FAIL: Moya, 4.0.3, 4b3ff7, Swift Package 
03:05:03 FAIL: NetService, 4.0, 51256c, Swift Package 
03:05:03 FAIL: NetService, 3.1, 4c20bd, Swift Package 
03:05:03 FAIL: Perfect, 3.0, 540feb, Swift Package 
03:05:03 FAIL: Plank, 4.0.3, fe7841, Swift Package 
03:05:03 FAIL: R.swift, 4.0, c5273e, Swift Package 
03:05:03 FAIL: R.swift, 3.0, ac56b8, Swift Package 
03:05:03 FAIL: Result, 4.0, 747758, Swift Package 
03:05:03 FAIL: Result, 3.1, 1a2a97, Swift Package 
03:05:03 FAIL: SwiftLint, 4.0, 549d4c, Swift Package 
03:05:03 ========================================

Each contains the error message: error: manifest parse error(s)

aciidgh commented 6 years ago

I think we should add diagnostics in SwiftPM explaining that we don't support v3 manifest anymore.

aciidgh commented 6 years ago

Also, related: https://forums.swift.org/t/removing-packagedescription-api-v3-master-branch/14109

clackary commented 6 years ago

@aciidb0mb3r Ah, thanks for the context. If it breaks this many of our source compat projects, it's bound to be pretty common, so I agree about adding diagnostics.

Bouke commented 6 years ago

Thanks Clack. I finally got around to resolve this issue for my projects, I've submitted these PRs: https://github.com/apple/swift-source-compat-suite/pull/269 and https://github.com/apple/swift-source-compat-suite/pull/270.