search

swiftlang / swift

The Swift Programming Language
https://swift.org
Apache License 2.0
66.99k stars 10.32k forks source link

[SR-10993] SwifterSwift fails in source compatibility test suite #53383

Closed nkcsgexi closed 4 years ago

nkcsgexi commented 5 years ago
Previous ID SR-10993
Radar rdar://problem/51976990
Original Reporter @nkcsgexi
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA | | | |------------------|-----------------| |Votes | 0 | |Component/s | | |Labels | Bug, SourceCompatibility | |Assignee | @lorentey | |Priority | Medium | md5: da1973eeaa60eae6b54c67879c6eb9cd

Issue Description:

00:47:39 Failures:

00:47:39 FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-watchOS, generic/platform=watchOS

00:47:39 FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-iOS, generic/platform=iOS

URL: https://ci.swift.org/view/Dashboard/job/swift-5.1-source-compat-suite/231/console

/Users/buildslave/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/SwifterSwift/Sources/Extensions/SwifterSwift.swift:13:5: error: failed to load module 'WatchKit'

belkadan commented 5 years ago

The watchOS and iOS failures are probably different: WatchKit was removed entirely from iOS, but not from watchOS.

belkadan commented 5 years ago

Yep, the iOS one is expected, and the watchOS is the weirdness around CoreMediaOverlayShims

lorentey commented 5 years ago

Submitted https://github.com/apple/swift/pull/25737 to work around the shims issue.

lorentey commented 5 years ago

Cherry picked to swift-5.1-branch in https://github.com/apple/swift/pull/25738.

DougGregor commented 4 years ago

This is fixed and the project is passing in the source compatibility suite now