search

swiftlang / swift

The Swift Programming Language
https://swift.org
Apache License 2.0
67.69k stars 10.39k forks source link

[SR-11420] Protocol Stubs Should Suggest Requirement Stubs for Renames As Well #53821

Open CodaFi opened 5 years ago

CodaFi commented 5 years ago
Previous ID SR-11420
Radar rdar://problem/55041530
Original Reporter @CodaFi
Type Bug

Attachment: Download

Additional Detail from JIRA | | | |------------------|-----------------| |Votes | 0 | |Component/s | Compiler | |Labels | Bug, DiagnosticsQoI, StarterBug | |Assignee | RoyCao (JIRA) | |Priority | Medium | md5: b5341cef12a65640a517d36946649164

Issue Description:

For some odd reason, we don't print requirements that we diagnose as "close enough" to another witness that we can offer a rename fixit. For requirements that nearly-match something in another module (especially one you don't control like Foundation), this means the stub we print is missing requirements and doesn't compile.

Look into the callers (or lack thereof) of swift::printRequirementStub to see why this is happening.

I've attached a small SwiftUI Mac app that tries to define a coordinator with a conformance to an Objective-C protocol that defines two requirements. If you open it up and try to build it, only one of the two requirement stubs is printed. The other notes that something in NSObject should be renamed. That remaining stub should be suggested and printed along with the other requirement.

CodaFi commented 5 years ago

@swift-ci create

swift-ci commented 4 years ago

Comment by CaoMing (JIRA)

I am interested in it and would like to fix🙂