search

swiftlang / swift

The Swift Programming Language
https://swift.org
Apache License 2.0
67.31k stars 10.34k forks source link

[SR-15106] Source compatibility suite: FAIL: Evergreen, 4.0, ce0d24, Evergreen, generic/platform=macOS: cannot find 'kInternetEventClass' in scope #57432

Open hamishknight opened 3 years ago

hamishknight commented 3 years ago
Previous ID SR-15106
Radar rdar://problem/82303293
Original Reporter @hamishknight
Type Bug
Environment swift-main-source-compat-suite swift-main-source-compat-suite-debug swift-5.5-source-compat-suite
Additional Detail from JIRA | | | |------------------|-----------------| |Votes | 0 | |Component/s | | |Labels | Bug | |Assignee | None | |Priority | Medium | md5: 0fb8fb20801b53805afc632d1abdfc65

Issue Description:

https://ci.swift.org/job/swift-main-source-compat-suite/6084/
https://ci.swift.org/job/swift-main-source-compat-suite-debug/4198/
https://ci.swift.org/job/swift-5.5-source-compat-suite/139/

Evergreen is failing to build with:


/Volumes/swift-ci/jenkins/workspace/swift-main-source-compat-suite/swift-source-compat-suite/project_cache/Evergreen/Evergreen/Scriptability/AppDelegate+Scriptability.swift:38:138: error: cannot find 'kInternetEventClass' in scope
        NSAppleEventManager.shared().setEventHandler(self, andSelector: #selector(AppDelegate.getURL(_:_:)), forEventClass: AEEventClass(kInternetEventClass), andEventID: AEEventID(kAEGetURL))
                                                                                                                                         ^~~~~~~~~~~~~~~~~~~
/Volumes/swift-ci/jenkins/workspace/swift-main-source-compat-suite/swift-source-compat-suite/project_cache/Evergreen/Evergreen/Scriptability/AppDelegate+Scriptability.swift:38:182: error: cannot find 'kAEGetURL' in scope
        NSAppleEventManager.shared().setEventHandler(self, andSelector: #selector(AppDelegate.getURL(_:_:)), forEventClass: AEEventClass(kInternetEventClass), andEventID: AEEventID(kAEGetURL))
                                                                                                                                                                                     ^~~~~~~~~
hamishknight commented 3 years ago

cc vincode_io (JIRA User)

hamishknight commented 3 years ago

XFAILing in https://github.com/apple/swift-source-compat-suite/pull/576

hamishknight commented 3 years ago

@swift-ci create

xymus commented 3 years ago

It looks like a direct import of `ApplicationServices` is now needed to use this decl. We're following up internally to determine if this was an intended dependency clean up or some other unintended change.

justice-adams-apple commented 2 years ago

Hi @brentsimmons 👋 . I noticed this XFAIL of evergreen on the source compatibility repository https://github.com/apple/swift-source-compat-suite/blob/main/projects.json#L808

This was determined to be source-related issue within https://github.com/Ranchero-Software/NetNewsWire/blob/e3f066aaf5175d09f51632261d98a421dab572b6/Mac/Scriptability/AppDelegate%2BScriptability.swift as mentioned above.

I noticed that the project has been renamed/updated extensively from the revision we have in the source compat suite. I'd recommend updating the project definition in the source compat suite if you want your project to be continuously tested with compiler changes