philipturner
commented
2 years ago I narrowed down the reproducer further, and the crash signature changed. It now crashes on toolchains as early as July 2020. If I add @inlinable, something peculiar happens. On older toolchains, it would crash just like if it didn't have @inlinable. On newer toolchains, the crash signature changes to what's mentioned in this issue's first comment.
import _Differentiation
public extension SIMD where Self: Differentiable, Scalar == Float {
// May be `@inlinable`, but adding that attribute may change the crash
// signature.
@derivative(of: sum)
func _vjpSum() -> (value: Float, pullback: (Float) -> TangentVector) {
fatalError()
}
}The crash for @inlinable changes between the 2022-03-09 and 2022-03-22 snapshots.
`@inlinable` crash
``` (base) philipturner@m1-max-mbp bug % swiftc file.swift error: compile command failed due to signal 6 (use -v to see invocation) SIL verification failed: internal/private function cannot be serialized or serializable: !F->isSerialized() In function: // reverse-mode derivative of SIMD<>.sum() sil hidden [serialized] [thunk] [always_inline] [ossa] @$ss4SIMDPsSF6ScalarRpzrlE3sumADyFsAARz16_Differentiation14DifferentiableRzSfACs11SIMDStoragePRtzlTJrSpSr : $@convention(method) <τ_0_0 where τ_0_0 : SIMD, τ_0_0 : Differentiable, τ_0_0.Scalar == Float> (@in_guaranteed τ_0_0) -> (@out Float, @owned @callee_guaranteed @substituted <τ_0_0> (@in_guaranteed Float) -> @out τ_0_0 for <τ_0_0.TangentVector>) { // %0 // user: %3 // %1 // user: %3 bb0(%0 : $*Float, %1 : $*τ_0_0): // function_ref SIMD<>._vjpSum() %2 = function_ref @$ss4SIMDP4file16_Differentiation14DifferentiableRzSf6Scalars11SIMDStoragePRtzrlE7_vjpSumSf5value_13TangentVectorAdEPQzSfc8pullbacktyF : $@convention(method) <τ_0_0 where τ_0_0 : SIMD, τ_0_0 : Differentiable, τ_0_0.Scalar == Float> (@in_guaranteed τ_0_0) -> (Float, @owned @callee_guaranteed @substituted <τ_0_0> (Float) -> @out τ_0_0 for <τ_0_0.TangentVector>) // user: %3 %3 = apply %2<τ_0_0>(%0, %1) : $@convention(method) <τ_0_0 where τ_0_0 : SIMD, τ_0_0 : Differentiable, τ_0_0.Scalar == Float> (@in_guaranteed τ_0_0) -> (Float, @owned @callee_guaranteed @substituted <τ_0_0> (Float) -> @out τ_0_0 for <τ_0_0.TangentVector>) // user: %4 (%4, %5) = destructure_tuple %3 : $(Float, @callee_guaranteed @substituted <τ_0_0> (Float) -> @out τ_0_0 for <τ_0_0.TangentVector>) // users: %10, %6 %6 = convert_function %5 : $@callee_guaranteed @substituted <τ_0_0> (Float) -> @out τ_0_0 for <τ_0_0.TangentVector> to $@callee_guaranteed (Float) -> @out τ_0_0.TangentVector // user: %8 // function_ref thunk for @escaping @callee_guaranteed (@unowned Float) -> (@out A.Differentiable.TangentVector) %7 = function_ref @$sSf13TangentVector16_Differentiation14DifferentiablePQzIegyr_SfAEIegnr_s4SIMDRzAbCRzSf6Scalars11SIMDStoragePRtzlTR : $@convention(thin) <τ_0_0 where τ_0_0 : SIMD, τ_0_0 : Differentiable, τ_0_0.Scalar == Float> (@in_guaranteed Float, @guaranteed @callee_guaranteed (Float) -> @out τ_0_0.TangentVector) -> @out τ_0_0.TangentVector // user: %8 %8 = partial_apply [callee_guaranteed] %7<τ_0_0>(%6) : $@convention(thin) <τ_0_0 where τ_0_0 : SIMD, τ_0_0 : Differentiable, τ_0_0.Scalar == Float> (@in_guaranteed Float, @guaranteed @callee_guaranteed (Float) -> @out τ_0_0.TangentVector) -> @out τ_0_0.TangentVector // user: %9 %9 = convert_function %8 : $@callee_guaranteed (@in_guaranteed Float) -> @out τ_0_0.TangentVector to $@callee_guaranteed @substituted <τ_0_0> (@in_guaranteed Float) -> @out τ_0_0 for <τ_0_0.TangentVector> // user: %10 %10 = tuple (%4 : $Float, %9 : $@callee_guaranteed @substituted <τ_0_0> (@in_guaranteed Float) -> @out τ_0_0 for <τ_0_0.TangentVector>) // user: %11 return %10 : $(Float, @callee_guaranteed @substituted <τ_0_0> (@in_guaranteed Float) -> @out τ_0_0 for <τ_0_0.TangentVector>) // id: %11 } // end sil function '$ss4SIMDPsSF6ScalarRpzrlE3sumADyFsAARz16_Differentiation14DifferentiableRzSfACs11SIMDStoragePRtzlTJrSpSr' Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace. Stack dump: 0. Program arguments: /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2022-03-22-a.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file file.swift -target arm64-apple-macosx12.0 -Xllvm -aarch64-use-tbi -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk -color-diagnostics -new-driver-path /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2022-03-22-a.xctoolchain/usr/bin/swift-driver -empty-abi-descriptor -resource-dir /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2022-03-22-a.xctoolchain/usr/lib/swift -module-name file -target-sdk-version 12.3 -o /var/folders/qn/86czb43d3pv03bfnxvb3x66h0000gn/T/TemporaryDirectory.lrqizI/file-1.o 1. Apple Swift version 5.7-dev (LLVM a70fc75b0dfacb7, Swift 687beace5e0c77a) 2. Compiling with the current language version 3. While evaluating request ASTLoweringRequest(Lowering AST to SIL for file "file.swift") 4. While verifying SIL function "@$ss4SIMDPsSF6ScalarRpzrlE3sumADyFsAARz16_Differentiation14DifferentiableRzSfACs11SIMDStoragePRtzlTJrSpSr". for '_vjpSum()' (at file.swift:6:3) Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it): 0 swift-frontend 0x0000000108dbd2b8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56 1 swift-frontend 0x0000000108dbc518 llvm::sys::RunSignalHandlers() + 128 2 swift-frontend 0x0000000108dbd91c SignalHandler(int) + 304 3 libsystem_platform.dylib 0x000000019cd194c4 _sigtramp + 56 4 libsystem_pthread.dylib 0x000000019cd01ee0 pthread_kill + 288 5 libsystem_c.dylib 0x000000019cc3c340 abort + 168 6 swift-frontend 0x0000000104a9f9a0 (anonymous namespace)::SILVerifier::_require(bool, llvm::Twine const&, std::__1::functionI have reproduced the vanilla crash as far back as the 2020-07-22 toolchain. This is also the crash signature for if you don't add @inlinable.
asl
jkshtj
Additional Detail from JIRA
| | | |------------------|-----------------| |Votes | 0 | |Component/s | | |Labels | Bug, AutoDiff | |Assignee | None | |Priority | Medium | md5: fda31536276ac9af6789e3146d3c3482Issue Description:
Starting with the 2022-03-13 nightly toolchain snapshot, the following simple custom VJP:
when placed in a file and built with `swiftc file.swift` causes an assertion failure of "SIL verification failed: internal/private function cannot be serialized or serializable: !F->isSerialized()". This was not present in the 2022-03-09 nightly snapshot toolchain, and seems to be a fairly recent regression.
The full assertion is as follows: