[SR-16059] Use Objc Symbol on Open Class will result on LLVM crash

[wendyliga]

Previous ID	SR-16059
Radar	None
Original Reporter	@wendyliga
Type	Bug

Environment

MacOS 12.3 Xcode 13.3 Apple Silicon

Additional Detail from JIRA

| | | |------------------|-----------------| |Votes | 3 | |Component/s | swift | |Labels | Bug | |Assignee | None | |Priority | Medium | md5: a3cbb25f5715e6769be453351054910c

Issue Description:

Whenever we use an objc symbol on open class on swift 5.6, compile it under bitcode + arm64 + release config + static, we will get a LLVM crash

example

import UIKit

open class HelloWorld {
   open func hello(){ 
       UI_USER_INTERFACE_IDIOM()
   }
}

Step to Reproduce

• clone https://github.com/wendyliga/simple_xcode

• run

   xcodebuild archive -target SwiftLibrary -configuration Release -arch arm64 -sdk iphoneos15.4

  log:

  SwiftCodeGeneration normal arm64 (in target 'SwiftLibrary' from project 'simple_xcode')
      cd /Users/wendy.liga/Developer/simple_xcode
      /Applications/Xcode_13.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file /Users/wendy.liga/Developer/simple_xcode/build/simple_xcode.build/Release-iphoneos/SwiftLibrary.build/Objects-normal/arm64/Bar.bc -embed-bitcode -target arm64-apple-ios15.4 -Xllvm -aarch64-use-tbi -O -disable-llvm-optzns -module-name SwiftLibrary -o /Users/wendy.liga/Developer/simple_xcode/build/simple_xcode.build/Release-iphoneos/SwiftLibrary.build/Objects-normal/arm64/Bar.o
  Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
  Stack dump:
  0.  Program arguments: /Applications/Xcode_13.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file /Users/wendy.liga/Developer/simple_xcode/build/simple_xcode.build/Release-iphoneos/SwiftLibrary.build/Objects-normal/arm64/Bar.bc -embed-bitcode -target arm64-apple-ios15.4 -Xllvm -aarch64-use-tbi -O -disable-llvm-optzns -module-name SwiftLibrary -o /Users/wendy.liga/Developer/simple_xcode/build/simple_xcode.build/Release-iphoneos/SwiftLibrary.build/Objects-normal/arm64/Bar.o
  1.  Apple Swift version 5.6 (swiftlang-5.6.0.323.62 clang-1316.0.20.8)
  2.  Compiling with the current language version
  3.  Running pass 'Function Pass Manager' on module '/Users/wendy.liga/Developer/simple_xcode/build/simple_xcode.build/Release-iphoneos/SwiftLibrary.build/Objects-normal/arm64/Bar.bc'.
  4.  Running pass 'ObjC ARC contraction' on function '@UI_USER_INTERFACE_IDIOM'
  Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
  0  swift-frontend           0x0000000104eeaf88 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
  1  swift-frontend           0x0000000104ee9f9c llvm::sys::RunSignalHandlers() + 112
  2  swift-frontend           0x0000000104eeb618 SignalHandler(int) + 344
  3  libsystem_platform.dylib 0x00000001b81054c4 _sigtramp + 56
  4  swift-frontend           0x0000000102e68e8c llvm::objcarc::BundledRetainClaimRVs::insertRVCallWithColors(llvm::Instruction*, llvm::CallBase*, llvm::DenseMap<llvm::BasicBlock*, llvm::TinyPtrVector<llvm::BasicBlock*>, llvm::DenseMapInfo<llvm::BasicBlock*>, llvm::detail::DenseMapPair<llvm::BasicBlock*, llvm::TinyPtrVector<llvm::BasicBlock*> > > const&) + 64
  5  swift-frontend           0x0000000102e79878 (anonymous namespace)::ObjCARCContract::run(llvm::Function&, llvm::AAResults*, llvm::DominatorTree*) + 1024
  6  swift-frontend           0x0000000104c5ee24 llvm::FPPassManager::runOnFunction(llvm::Function&) + 1292
  7  swift-frontend           0x0000000104c6538c llvm::FPPassManager::runOnModule(llvm::Module&) + 60
  8  swift-frontend           0x0000000104c5f5a8 llvm::legacy::PassManagerImpl::run(llvm::Module&) + 1088
  9  swift-frontend           0x0000000100c2aee8 swift::performLLVMOptimizations(swift::IRGenOptions const&, llvm::Module*, llvm::TargetMachine*) + 3376
  10 swift-frontend           0x0000000100c2be28 swift::performLLVM(swift::IRGenOptions const&, swift::DiagnosticEngine&, llvm::sys::SmartMutex<false>*, llvm::GlobalVariable*, llvm::Module*, llvm::TargetMachine*, llvm::StringRef, swift::UnifiedStatsReporter*) + 2440
  11 swift-frontend           0x0000000100c34364 swift::performLLVM(swift::IRGenOptions const&, swift::ASTContext&, llvm::Module*, llvm::StringRef) + 180
  12 swift-frontend           0x000000010078cea0 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 6976
  13 swift-frontend           0x0000000100754130 swift::mainEntry(int, char const**) + 808
  14 dyld                     0x00000001076cd088 start + 516
  error: Segmentation fault: 11 (in target 'SwiftLibrary' from project 'simple_xcode')
  
  error: backend command failed due to signal 11 (use -v to see invocation)
  ** ARCHIVE FAILED **

[wendyliga]

I also can confirm the issue exists on non apple silicon (macOS 12.2 + Xcode 13.3)

[wendyliga]

the issue does not appear on Xcode 13.2.1

[swift-ci]

Comment by Tobias Löfstrand (JIRA)

Can also confirm that issue does not appear on Xcode 13.2.1.

Additionally, in my case, I was able to solve the problem by replacing a call to the old

UI_USER_INTERFACE_IDIOM function, with a call to UIDevice.current.userInterfaceIdiom.

[wendyliga]

issue hasn't been fixed on Xcode 13.3.1