swiftlang / swift

The Swift Programming Language
https://swift.org
Apache License 2.0
67.61k stars 10.37k forks source link

[update-checkout] Windows dependencies weren't checked out #60457

Open stevapple opened 2 years ago

stevapple commented 2 years ago

Is your feature request related to a problem? Please describe. A standard Swift on Windows toolchain builds ICU, SQLite 3, libxml2 and curl (zlib) from source, but these repositories aren't checked out by default.

Describe the solution you'd like update-checkout should be able to check out all the repositories that are necessary to build Swift, instead of requiring manual clones or fetching while building.

Add these repositories to update-checkout-config.json. ICU in Windows toolchain is newer than that on Linux, and possibly we can bump Linux version or alias it as icu-windows. SQLite requires a slightly different way of building, which may result in additional build tools to be used.

Describe alternatives you've considered vcpkg can be used for building and integrating libraries with CMake, but it's not used in standard build process yet.

Additional context Add any other context or screenshots about the feature request here.

stevapple commented 1 year ago

Is this solved by https://github.com/apple/swift/pull/69555? @compnerd