swiftlang / swift

The Swift Programming Language
https://swift.org
Apache License 2.0
67.31k stars 10.34k forks source link

Source compat project 'vapor_sql-kit' fails on a compilation error #75655

Open xymus opened 1 month ago

xymus commented 1 month ago

Description

https://ci.swift.org/job/swift-main-source-compat-suite-debug/854/

Reproduction

Error:

/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/vapor_sql-kit/Tests/SQLKitTests/BaseTests.swift:39:71: error: use of protocol 'Encodable' as a type must be written 'any Encodable'
 37 |     
 38 |     func testInsertWithArrayOfEncodable() {
 39 |         func weird(_ builder: SQLInsertBuilder, values: some Sequence<Encodable & Sendable>) -> SQLInsertBuilder {
    |                                                                       `- error: use of protocol 'Encodable' as a type must be written 'any Encodable'
 40 |             builder.values(Array(values))
 41 |         }

/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/vapor_sql-kit/Tests/SQLKitTests/BaseTests.swift:39:83: error: use of protocol 'Sendable' as a type must be written 'any Sendable'
 37 |     
 38 |     func testInsertWithArrayOfEncodable() {
 39 |         func weird(_ builder: SQLInsertBuilder, values: some Sequence<Encodable & Sendable>) -> SQLInsertBuilder {
    |                                                                                   `- error: use of protocol 'Sendable' as a type must be written 'any Sendable'
 40 |             builder.values(Array(values))
 41 |         }
/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/vapor_sql-kit/Tests/SQLKitTests/BaseTests.swift:39:71: error: use of protocol 'Encodable' as a type must be written 'any Encodable'
 37 |     
 38 |     func testInsertWithArrayOfEncodable() {
 39 |         func weird(_ builder: SQLInsertBuilder, values: some Sequence<Encodable & Sendable>) -> SQLInsertBuilder {
    |                                                                       `- error: use of protocol 'Encodable' as a type must be written 'any Encodable'
 40 |             builder.values(Array(values))
 41 |         }

/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite-debug/swift-source-compat-suite/project_cache/vapor_sql-kit/Tests/SQLKitTests/BaseTests.swift:39:83: error: use of protocol 'Sendable' as a type must be written 'any Sendable'
 37 |     
 38 |     func testInsertWithArrayOfEncodable() {
 39 |         func weird(_ builder: SQLInsertBuilder, values: some Sequence<Encodable & Sendable>) -> SQLInsertBuilder {
    |                                                                                   `- error: use of protocol 'Sendable' as a type must be written 'any Sendable'
 40 |             builder.values(Array(values))
 41 |         }

Expected behavior

Builds without errors.

Environment

It appears to fail only on main.

Additional information

No response

slavapestov commented 1 month ago

@AnthonyLatsis Is this related to your recent changes?

AnthonyLatsis commented 1 month ago

It is, these are legit errors. What is the usual course of action in this case? Fixing this in the vapor repo is a piece of cake, but the revision selected for the suite should be something stable like a release, right?

AnthonyLatsis commented 1 month ago

Okay, I think I got this.

justice-adams-apple commented 1 month ago

@AnthonyLatsis once the patch lands I can open a PR to update the revision of vapor_sql_kit on the compat suite and tag the maintainer for review