search

swiftlang / swift

The Swift Programming Language
https://swift.org
Apache License 2.0
67.6k stars 10.37k forks source link

[build] Build sourcekit-lsp for multiple arches and lipo them #76730

Closed ahoppen closed 1 month ago

ahoppen commented 1 month ago

Instead of building SourceKit-LSP using SwiftPM's multi-arch xcbuild backend, build it for only one arch at a time and then run lipo to merge the two resulting binaries.

This should allow us to share build products between building installing and testing and also eliminates other quirks resulting from the xcbuild backend.

ahoppen commented 1 month ago

https://github.com/swiftlang/sourcekit-lsp/pull/1717

@swift-ci Please test

ahoppen commented 1 month ago

https://github.com/swiftlang/sourcekit-lsp/pull/1717

@swift-ci Please build toolchain

ahoppen commented 1 month ago

Toolchain builds succeeded. Just fixing Python lint issues now, so won’t run another toolchain build.

ahoppen commented 1 month ago

@swift-ci Please smoke test

ahoppen commented 1 month ago

Yes, that’s done by build-script-impl if I remember correctly.