[Windows] Enable "INLINE" bridging mode

swiftlang / swift

The Swift Programming Language

https://swift.org

Apache License 2.0

67.6k stars 10.37k forks source link

[Windows] Enable "INLINE" bridging mode #76754

Closed rintaro closed 1 month ago

rintaro commented 1 month ago

Workaround for https://github.com/swiftlang/llvm-project/issues/7172
-D_CRT_USE_BUILTIN_OFFSETOF to make offsetof() a constant
Pass swift/shims search path in SwiftCompilerSources

rintaro commented 1 month ago

@swift-ci Please smoke test

rintaro commented 1 month ago

@swift-ci Please smoke test

rintaro commented 1 month ago

@swift-ci Please smoke test

eeckstein commented 1 month ago

@hjyamauchi Can you please check if the "inline" bridging mode also works for windows arm? I.e. try with a recent top-of-main

hjyamauchi commented 1 month ago

@hjyamauchi Can you please check if the "inline" bridging mode also works for windows arm? I.e. try with a recent top-of-main

Sure. What does the inline bridging mode mean?

eeckstein commented 1 month ago

It basically means that many stl/llvm/swift headers are included in the bridging modules, i.e. imported by the clang importer. This is not the case in the "pure" mode, which was used for Windows prior to this change.