search

swiftlang / swift

The Swift Programming Language
https://swift.org
Apache License 2.0
67.6k stars 10.37k forks source link

[embedded] Skip C++ stdlib for unicode stubs #76761

Closed bnbarham closed 1 month ago

bnbarham commented 1 month ago

stdint.h should be picked up from clang/lib/Headers, but is instead being picked up by the system libc++. There's no C++ stdlib being used here, so just exclude it.

Resolves rdar://134584685.

bnbarham commented 1 month ago

@swift-ci please test

kubamracek commented 1 month ago

Nice, I didn't think of that. If this actually resolves the issue, LGTM!

bnbarham commented 1 month ago

Nice, I didn't think of that. If this actually resolves the issue, LGTM!

Did locally, but we'll see :)

bnbarham commented 1 month ago

@swift-ci build toolchain Ubuntu 22.04

bnbarham commented 1 month ago

@swift-ci build toolchain Ubuntu 22.04

bnbarham commented 1 month ago

I think we should audit the rest of embedded targets and pass this flag for those targets too.

The only other is concurrency and apparently that's not actually at the point of building right now anyway.