Update tests so Ubuntu 18.04 tests stop failing

swiftlang / swiftly

A Swift toolchain installer and manager, written in Swift.

https://swiftlang.github.io/swiftly/

Apache License 2.0

470 stars 24 forks source link

Update tests so Ubuntu 18.04 tests stop failing #126

Closed adam-fowler closed 2 months ago

adam-fowler commented 3 months ago

Alternatively we could just remove Ubuntu 1804 from CI.

adam-fowler commented 3 months ago

@patrickfreed thoughts?

0xTim commented 3 months ago

We should probably just remove it since it's EOL

shahmishal commented 3 months ago

Disabled: https://ci.swiftserver.group/job/swiftly-ubuntu1804-prb/ and https://ci.swiftserver.group/job/swiftly-ubuntu1804-install-prb/

patrickfreed commented 3 months ago

I think it's fine to disable them for now since they're failing anyways, but I think it could also makes sense to fix the tests later and continue to support swiftly on these platforms for the purposes of installing the older toolchains. There's a bit more discussion on https://github.com/swiftlang/swiftly/issues/100 about how to handle this situation.