Open BrianHenryIE opened 1 month ago
We haven't released a macOS version of swiftly yet.
Yeah, I'm testing the changes that have been merged to main
https://github.com/swiftlang/swiftly/pull/121#issuecomment-2225762591
Please raise issues for anything that remains. Thanks everyone!
The plan is for a lot of the swiftly-install script to be moved inside of swiftly. The current state of the script is not Mac friendly.
Brief thread on Slack, FYI: https://swift-open-source.slack.com/archives/C078M3HTMEU/p1720899355984949, basically just saying I want to test this.
I still have more use-testing to do to be 100% sure, but I think if my two PRs are merged, then macOS support is ready for a release.
I agree 100% that it's preferable to eliminate swiftly-install.sh
. My reading of the discussion is that that is a different task, and it has a PR proposal but looks like it's not imminent. If it is imminent, hopefully the comments I've made here will be helpful.
Let me know if there's an expectation of automated tests – I said elsewhere that hopefully it's a matter of adding a macOS target for testing rather than writing new tests. The two "suggestion" issues I've opened probably would want tests when I write PRs.
https://github.com/swiftlang/swiftly/blob/bcfd8439a078893c11d3331c193e2b6a7b431887/install/swiftly-install.sh#L489-L503
https://github.com/swiftlang/swiftly/blob/bcfd8439a078893c11d3331c193e2b6a7b431887/install/swiftly-install.sh#L657-L659
Removing the conditionals allows
swiftly
to run, but the config is mostly empty:And installing doesn't work: