search

swiftlang / swiftly

A Swift toolchain installer and manager, written in Swift.
https://swiftlang.github.io/swiftly/
Apache License 2.0
473 stars 24 forks source link

Run shellcheck on swiftly-install.sh #64

Open patrickfreed opened 1 year ago

patrickfreed commented 1 year ago

shellcheck is a static analysis tool for bash which can catch a number of common bash issues. We should run it on swiftly-install.sh and include it in the soundness check CI task.

adam-fowler commented 1 year ago

This should be part of the CI setup as well

Zingam commented 9 months ago

bash is a kind of deprecated on macOS. Better use posix shell for max compatibility.

adam-fowler commented 9 months ago

bash is a kind of deprecated on macOS. Better use posix shell for max compatibility.

Do you mean deprecated in that it isn't the default shell on macOS anymore or that Apple intend to delete it in a future release of macOS. If it is the second can you post where Apple announced this.

Currently bash is available on pretty much every Linux release. I'll have to let @patrickfreed cover any issues with falling back to posix shell.

cmcgee1024 commented 2 weeks ago

I think we should close this as the installer is now written in Swift.

Gingeh commented 1 week ago

I think we should close this as the installer is now written in Swift.

https://github.com/swiftlang/swiftly/blob/a7ef9e838b21b7f2836f318e67b4bffa6bee259f/install/swiftly-install.sh (the script this issue is talking about) is not written in swift

cmcgee1024 commented 1 week ago

@Gingeh the shell scripts has been replaced by the swiftly init subcommand. Before next release we will be removing the shell script entirely in favour of guidance on the swift.org download page that gets the user to that subcommand to complete the installation.