swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
754 stars 54 forks source link

Add tests for the Swift snippets workflows #1126

Open award999 opened 4 weeks ago

award999 commented 4 weeks ago

Issue: #1125

michael-weng commented 3 weeks ago

The CI will probably make this apparent so might just be stating the obvious here, but snippet's only implemented in 5.7 so probably need to set some precondition. https://github.com/swiftlang/swift-evolution/blob/main/proposals/0356-swift-snippets.md

award999 commented 3 weeks ago

The CI will probably make this apparent so might just be stating the obvious here, but snippet's only implemented in 5.7 so probably need to set some precondition. https://github.com/swiftlang/swift-evolution/blob/main/proposals/0356-swift-snippets.md

yep thanks :), also seems like it was hidden behind an experimental flag for a bit so trying to run that down

michael-weng commented 3 weeks ago

The CI will probably make this apparent so might just be stating the obvious here, but snippet's only implemented in 5.7 so probably need to set some precondition. https://github.com/swiftlang/swift-evolution/blob/main/proposals/0356-swift-snippets.md

yep thanks :), also seems like it was hidden behind an experimental flag for a bit so trying to run that down

Nice! If it's a particular flag we are expecting would be a good candidate for a separate contract test, and if anything were to change we will know explicit the contract with the driver's broken.