swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
726 stars 50 forks source link

The swift-lldb debugger shows various spinners that cannot be dismissed #666

Closed tristanlabelle closed 6 months ago

tristanlabelle commented 7 months ago

Describe the bug When debugging using swift-lldb, various message boxes/spinners appear and don't go away until the debugging session completes.

To Reproduce (unclear what kind of project makes this happen, but this has been reported by various people)

image image image

Expected behavior Any spinners should either eventually disappear or provide a way to be dismissed.

Environment

adam-fowler commented 7 months ago

Are you sure these are coming from the vscode-swift extension? The debug adapter itself cannot display messages. It is a separate process from VSCode. You don't have any other extensions that could be displaying these. I have gone through all the extension's usage of showInformationMessage and they all display static strings and none of them are the strings you are seeing.

Has this always occurred, or is it a recent thing?

adam-fowler commented 7 months ago

I've had a quick look through the lldb-vscode code and there does appear to be a Progress type that these string are being sent to. The DAP spec also has support for progress messages. I'm guessing VSCode is reading these and displaying information windows for them. I'll look into it further

tristanlabelle commented 7 months ago

Ah that looks right! There must be some ProgressStart event that's not properly coupled with a ProgressEnd one. Should I migrate this to llvm/llvm-project then?

I'm not clear on whether this is a recent regression. It could also be dependent on the code we are debugging.

adam-fowler commented 7 months ago

Ah that looks right! There must be some ProgressStart event that's not properly coupled with a ProgressEnd one. Should I migrate this to llvm/llvm-project then?

I'm not clear on whether this is a recent regression. It could also be dependent on the code we are debugging.

I had a very very Quick Look at the llvm lldb-vscode code and didn't see anything obvious.

adam-fowler commented 6 months ago

@tristanlabelle Did you get anywhere with this?

tristanlabelle commented 6 months ago

We're sitting on this item in the backlog and it will likely be a few more weeks before we look into it. Personally I'm satisfied that this looks like a DAP bug and we can close the issue here.