Parser serialized diagnostic file instead of scraping diagnostics from the build log

[ahoppen]

Instead of scraping the build log for errors/warnings/notes using a regex, it would be cleaner if the VS Code extension would read the diagnostic file emitted by -serialize-diagnostics-path. That way VS Code could also show notes that are attached to errors as their children, instead of displaying them as a top level problem.

[adam-fowler]

When did this go in? I know it was being planned but didn't know what state it was in.

[ahoppen]

What do you mean by “this“? AFAIK the Swift compiler has been able to emit serialized diagnostic files for quite a while, possibly forever.

[adam-fowler]

Ok I didn't know about it. Anyway VSCode expects extensions to be parsing compiler output to produce the output of the problems pane. It doesn't really have an interface for extensions to add problems, well at least not a publicly advertised one. What you are suggesting kinda goes against what VSCode expects of extensions. I'll leave this open , as there might be a way, but can't guarantee anything.

[ahoppen]

Oh, interesting. I would have expected that other languages also used serialized diagnostics to produce structured diagnostics.

[daveyc123]

This relates to #750 and the coordination between diagnostics that come from parsing the output of a task and the diagnostics that come out of source kit lsp.

[award999]

happy to grab this one