search

swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
713 stars 47 forks source link

When disabling sourcekit-lsp in settings, the popup implies the server will be restarted #747

Closed z2oh closed 1 month ago

z2oh commented 3 months ago

The popup window defined here says "Changing LSP settings requires the language server be restarted." but of course if the setting changed was to disable sourcekit-lsp, the server doesn't actually get restarted.

Describe the solution you'd like This setting should probably be special cased with a message like "Sourcekit-lsp disabled. Click OK to shut down language server." or the like.

award999 commented 1 month ago

Verified with bee8ce39dc91d99718797f3bcece2a3289d8b38b