swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
709 stars 47 forks source link

Use nvm for CI builds #787

Closed award999 closed 1 month ago

award999 commented 1 month ago

To make sure all contributors are using the same version of node.js as the CI build, we should create a .nvmrc file that is in sync with https://github.com/microsoft/vscode/blob/main/.nvmrc and update the Dockerfile to use nvm instead of installing a set version. Update https://github.com/swift-server/vscode-swift/blob/main/CONTRIBUTING.md to indicate nvm setup

adam-fowler commented 1 month ago

Done