search

swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
708 stars 47 forks source link

Deprecate the `swift.sourcekit-lsp.serverPath` setting #836

Closed ahoppen closed 1 month ago

ahoppen commented 1 month ago

Mixing and matching SourceKit-LSP servers and Swift toolchains is only supported in limited scenarios because they need to line up to a fair degree. The swift.sourcekit-lsp.serverPath setting is tremendously useful for SourceKit-LSP developers but I don’t think it should be exposed to general users. In some offline chats, we discussed if it makes sense to mark the setting as deprecated with a message like Only intended for debugging of SourceKit-LSP, which should hide it from the settings UI and thus from normal users. SourceKit-LSP developers will need to be told about the settings key and modify their settings.json manually.

plemarquand commented 1 month ago

This has already been marked as deprecated here: https://github.com/swift-server/vscode-swift/blob/main/package.json#L334 in https://github.com/swift-server/vscode-swift/pull/777.

If you're using the extension built from main and still seeing the setting in your settings UI it is likely because it has a value set. Otherwise this will be deprecated in the upcoming release.

ahoppen commented 1 month ago

Oh, great. I didn’t see that. Thanks!