search

swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
708 stars 47 forks source link

Fix flakey pipe removal #837

Closed plemarquand closed 4 weeks ago

plemarquand commented 1 month ago

On posix platforms if a named pipe hasn't been written to then occasionally calls to fs.lstat (which I believe fs.rm uses internally) will hang indefinitely.

If a test run failed due to a compiler error in the build then the pipe never be written to. By repeatedly trying to perform a test run with code that fails to compile eventually this hang would appear.

Work around the issue by writing to the pipe if compilation fails, ensuring the connection opens/closes and the pipe can be removed

adam-fowler commented 1 month ago

The other solution would be to write a dummy line to the named pipe.

plemarquand commented 1 month ago

@adam-fowler You're right, I think this works better and is more close to the source of the issue, which is that if the other side of a pipe never opens then the hang is possible.