search

swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
706 stars 47 forks source link

Fix flakey pipe removal for debug runs #845

Closed plemarquand closed 3 weeks ago

plemarquand commented 3 weeks ago

837 fixed this for regular runs, but more work was required for debug runs

plemarquand commented 3 weeks ago

@swift-server-bot test this please

adam-fowler commented 3 weeks ago

I guess this works, but it seems more sensible to move the test building outside of the TemporaryFolder.withNamedTemporaryFile closure. Or at least create the fifo once we have built the tests and only if we have swift-testing tests.

plemarquand commented 3 weeks ago

I agree this isn’t ideal. I’m planning on revisiting this next week with the approach you outlined.