Reorder running of tests through debugger

swiftlang / vscode-swift

Visual Studio Code Extension for Swift

https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang

Apache License 2.0

706 stars 47 forks source link

Reorder running of tests through debugger #852

Closed adam-fowler closed 2 weeks ago

adam-fowler commented 3 weeks ago

Currently we do the following (as I understand)

create a pipe
If there are swift-testing tests create a test config
If there are xctest tests create a test config
build tests (via preLaunchTask)
run tests
delete pipe

Perhaps it should be

build tests
If there are swift-testing tests create a test config and pipe
If there are xctest tests create a test config
run tests
delete pipe if it exists

plemarquand commented 2 weeks ago

After some changes in other PRs I feel like the current debugging flow matches the proposed one. Let me know if you'd like me to make some changes related to this, but for now I'll close this out.

adam-fowler commented 2 weeks ago

After some changes in other PRs I feel like the current debugging flow matches the proposed one. Let me know if you'd like me to make some changes related to this, but for now I'll close this out.

Are we certain we are only creating a pipe when we need it?

plemarquand commented 2 weeks ago

Good call, I did find that we're creating the pipe when there are no swift-testing tests when debugging.

award999 commented 2 weeks ago

Verified with e548b63188333a84ade036e183a2b90656d64b4f