swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
706 stars 47 forks source link

Always register the swift-lldb debug adapter provider #886

Closed award999 closed 2 weeks ago

award999 commented 2 weeks ago

Issue: #848

We can always register this and that way the user does not need to reload the window when use change to using lldb-dap. Now they can use the updated debug configurations right away

award999 commented 2 weeks ago

@adam-fowler the debug session does nothing if the path does not exist or cannot find in toolchain, so added a check to verify that the the debug adapter does exist so the user gets an error message instead of silently failing. I see that we are already listening to changes to swift.debugger.useDebugAdapterFromToolchain and swift.debugger.path settings, else where so seemed a little more complex than necessary to listen to this again to register the debug provider