Add UI Settings Group - Githubissues

swiftlang / vscode-swift

Visual Studio Code Extension for Swift

https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang

Apache License 2.0

755 stars 54 forks source link

Add UI Settings Group #913

Closed plemarquand closed 4 months ago

plemarquand commented 4 months ago

Move the following settings in to their own group. Their ID does not change so there is no need to deprecate them or make code changes.

swift.excludePathsFromPackageDependencies
swift.showBuildStatus
swift.showCreateSwiftProjectInWelcomePage
swift.openAfterCreateNewProject

Issue #901

award999 commented 4 months ago

Debugger and SourceKit-LSP settings put something in the setting ID. So we could add .userInterface to these settings (ex. swift.userInterface.showBuildStatus) to follow that theme and would show that category in the Settings editor (ex. Swift › User Interface: Show Build Status). Now 3 of these settings are fairly new so not quite as concerned about changing them as not too many people should have set, but swift.excludePathsFromPackageDependencies has been around a little longer so not sure how concerned we should be

plemarquand commented 4 months ago

Yeah I was hesitant to change the actual setting IDs as these settings have been released and so we'd need to maintain/migrate them. Does adding a segment to the ID have any benefit other than code clarity?

award999 commented 4 months ago

Shows up marginally nicer in the Setting editor, ex. Swift › User Interface: Show Build Status

adam-fowler commented 4 months ago

This would mean we would have to deprecate the old settings and point people to the new ones. Unless we are making a significant gain I wouldn't bother changing them.