swiftlang / vscode-swift

Visual Studio Code Extension for Swift
https://marketplace.visualstudio.com/items?itemName=sswg.swift-lang
Apache License 2.0
755 stars 54 forks source link

Prompt to update `DEVELOPER_DIR` for macOS toolchain selection #938

Closed matthewbastien closed 4 months ago

matthewbastien commented 4 months ago

This updates the toolchain selection workflow to also set the DEVELOPER_DIR environment variable on macOS. This will be done automatically if the user selected an Xcode toolchain. However, they will be prompted to select a developer directory if they select a public Swift toolchain and there is more than one Xcode application installed on their system.

Linux and Windows toolchain selection is unaffected by this change.

Issue: #911

adam-fowler commented 4 months ago

We need to make it clear why you need the DEVELOPER_DIR, as it is not clear to me what the swift downloaded toolchains use from Xcode. @dschaefer2 perhaps you can answer that

dschaefer2 commented 4 months ago

We need to make it clear why you need the DEVELOPER_DIR, as it is not clear to me what the swift downloaded toolchains use from Xcode. @dschaefer2 perhaps you can answer that

The macOS SDK? Lots of good stuff in there :).

matthewbastien commented 4 months ago

@swift-server-bot test this please