Closed swiftlysingh closed 4 years ago
rarcilla
commented
4 years ago Hi, I'm interested in contributing to the project! Here are the mockups I made of the buttons:
Also to confirm, the code required to complete this issue doesn't require handling the api is that right? Ie that info is assumed to be be passed in, and I would just need to handle the logic to show the correct button?
swiftlysingh
commented
4 years ago The API calls have been handled although you would need to handle the decoding of the data. As of now decoded doesn't decode the links I believe.
About the design, can you send me a home screen mockup with this watch now button? I personally don't like the Play button. @rarcilla
swiftlysingh
commented
4 years ago Are you thinking of working on it? If yes I will assign this issue to you. @rarcilla
rarcilla
commented
4 years ago @pushpinderpalsingh I think I’ll pass on this issue - someone else could take it.
swiftlysingh
commented
4 years ago No issues. Great to have you here, anyways 😃
jkreller
commented
4 years ago Hey @pushpinderpalsingh! I would like to try that issue! I made the following mockup according to @rarcilla's buttons. The color is taken from the "Active" badge to keep in the apps color scheme. I would reduce the size of the lower buttons ("Rockets", "All launches", ...) to fit the new one. Also I would only display the active button. If no live stream is active / given I would just not display the button.
swiftlysingh
commented
4 years ago Sure thing. I am assigning this to you. While you are here, do 🌟 the repo if you haven't already!!
I don't think we have enough space to incorporate the watch now button on smaller iPhones. Although if you can find a way to better fit the watch now button on smaller iPhones, I am open to it. I believe reducing the size of the lower buttons might work.
What is your idea/feature: Add a Watch Now button for Upcoming Launch
Why this is beneficial: A watch now button will help to direct our users to the live stream of the upcoming launch. This will make our app more intuitive.
Solutions: The SpaceX API in most cases returns a Youtube link for most of the upcoming launch. When the link is available there should be a green clickable button for watch now else it should be a greyish non-clickable button.
Additional context Before making the requested changes in code make a mockup and comment it down below. After it is approved by me only then start with code.