search

swiftlysingh / SpaceDash

A Dashboard for Space...🚀🚀🚀
https://pushpinderpalsingh.github.io/SpaceDash/
MIT License
31 stars 20 forks source link

Added customising app icon feature #71

Closed rajhraval closed 3 years ago

rajhraval commented 3 years ago

Based on #47 I have added the stated feature in this PR.

Reverted back to original design. Added a button to open a page sheet which provides a segmented control to change the app icon. State is saved by UserDefaults.

Screenshots for the stated featured:

Click on Change App Icon Select an App Icon Icon is Changed
Simulator Screen Shot - iPhone 12 Pro - 2020-10-26 at 16 47 44 Simulator Screen Shot - iPhone 12 Pro - 2020-10-26 at 16 47 48 Simulator Screen Shot - iPhone 12 Pro - 2020-10-26 at 16 47 50

Waiting for feedback and review!

rajhraval commented 3 years ago

That actually doesn't look ideal in my opinion. I think entire table view controller (like Settings App) is better or the Page Sheet for Icon Picker is better.

Because, mostly they (Icon Picker) are either collection view based or table view based in form of sheet/full page.

For a new redesign, I have much better plans for the About Module.

swiftlysingh commented 3 years ago

Ok, since you are saying you plan to redesign About Screen, I will accept this design but with some minor adjustments. Remove the license button with all its supporting code and resize the font of Change App Icon to match that of the privacy policy button.

rajhraval commented 3 years ago

Done with the changes.

swiftlysingh commented 3 years ago

Thanks for your contribution! @all-contributors add @rajhraval1 for code

allcontributors[bot] commented 3 years ago

@pushpinderpalsingh

I've put up a pull request to add @rajhraval1! :tada: