swiftwasm / JavaScriptKit

Swift framework to interact with JavaScript through WebAssembly.
https://swiftpackageindex.com/swiftwasm/JavaScriptKit/main/documentation/javascriptkit
MIT License
693 stars 45 forks source link

Bump version to 0.14.0, update `CHANGELOG.md` #181

Closed MaxDesiatov closed 2 years ago

MaxDesiatov commented 2 years ago

New release is required to resolve https://github.com/TokamakUI/Tokamak/pull/475.

I've also cleaned up formatting in .ts file and clarified version incompatibility error message.

github-actions[bot] commented 2 years ago

Time Change: +1,152.5ms (10%) ⚠ī¸

Total Time: 11,165ms

Test name Duration Change
Serialization/Swift Int to JavaScript 3,350.5ms +277.25ms (8%) 🔍
Serialization/Swift String to JavaScript 3,923.75ms +893.25ms (22%) 🚨
ℹī¸ View Unchanged | Test name | Duration | Change | | :--- | :---: | :---: | | Serialization/Write JavaScript number directly | 220ms | +2.5ms (1%) | | Serialization/Write JavaScript string directly | 221ms | 0ms | | Object heap/Increment and decrement RC | 3,449.75ms | -20.5ms (0%) |

performance-action

kateinoigakukun commented 2 years ago

BTW I think this new release is not required for the Tokamak PR. Is there any essential change?

MaxDesiatov commented 2 years ago

https://github.com/swiftwasm/carton/pull/310 relies on reactor model, which was updated in https://github.com/swiftwasm/JavaScriptKit/pull/180, wasn't it? And then .jsValue() -> .jsValue change was breaking, I'd like to update Tokamak codebase for it sooner rather than later.

Either way, I've already tagged it, sorry if that was premature 😅

kateinoigakukun commented 2 years ago

180 is only for test harnesses, so no change in the js runtime. Yeah, it's fine to release breaking changes soon.