swiftwasm / JavaScriptKit

Swift framework to interact with JavaScript through WebAssembly.
https://swiftpackageindex.com/swiftwasm/JavaScriptKit/main/documentation/javascriptkit
MIT License
664 stars 44 forks source link

Prefer `UInt(bitPattern:)` for object id to guarantee uniqueness #219

Closed kateinoigakukun closed 1 year ago

kateinoigakukun commented 1 year ago

Close https://github.com/swiftwasm/JavaScriptKit/issues/218

github-actions[bot] commented 1 year ago

Time Change: -141ms (0%)

Total Time: 20,533ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 23ms -2ms (8%)
Serialization/JavaScript function call through Wasm import with int 22ms -1ms (6%)
View Unchanged | Test name | Duration | Change | | :--- | :---: | :---: | | Serialization/JavaScript function call from Swift | 194ms | -4ms (2%) | | Serialization/Swift Int to JavaScript with assignment | 515ms | +3ms (0%) | | Serialization/Swift Int to JavaScript with call | 1,607ms | -19ms (1%) | | Serialization/JavaScript Number to Swift Int | 529ms | -6ms (1%) | | Serialization/Swift String to JavaScript with assignment | 591ms | -6ms (1%) | | Serialization/Swift String to JavaScript with call | 1,709ms | -49ms (2%) | | Serialization/JavaScript String to Swift String | 6,334ms | -161ms (2%) | | Object heap/Increment and decrement RC | 8,987ms | +107ms (1%) |
View Baselines | Test name | Duration | | :--- | :---: | | Serialization/Call JavaScript function directly | 4ms | | Serialization/Assign JavaScript number directly | 3ms | | Serialization/Call with JavaScript number directly | 7ms | | Serialization/Write JavaScript string directly | 4ms | | Serialization/Call with JavaScript string directly | 4ms |
sidepelican commented 1 year ago

Thanks!