Figure out how to handle incompatible overrides

swiftwasm / WebAPIKit

Access the DOM and other Web APIs from Swift! (Very much a WIP)

MIT License

61 stars 8 forks source link

Figure out how to handle incompatible overrides #35

Closed j-f1 closed 1 year ago

j-f1 commented 2 years ago

These four symbols override something from their parent in an incompatible way. I think the best way forward would be to manually define extensions to those types using a slightly different name, but I’m not sure.

https://github.com/swiftwasm/DOMKit/blob/070f99efca195eaa38f46beeb4dc46ca1d6ce04b/Sources/WebIDLToSwift/IDLBuilder.swift#L89-L93

j-f1 commented 1 year ago

Some of those have been helpfully cleaned up by spec authors, but I’ve also manually patched the ones that haven’t been (such as BeforeUnloadEvent.returnValue) to a different name (here, returnValueAsString)