swiftwasm / WebAPIKit

Access the DOM and other Web APIs from Swift! (Very much a WIP)
MIT License
61 stars 8 forks source link

Update to JavaScriptKit 0.11.1 #8

Closed revolter closed 2 years ago

revolter commented 3 years ago

I'm not sure that I did it correctly, but I need this change in order to use the latest version of Tokamak.

MaxDesiatov commented 2 years ago

Thanks for the PR, and sorry for the delay. It looks like SwiftWasm 5.5 release is imminent, and we'd like to update JavaScriptKit with support for async/await, which may make a lot of things in this PR outdated. It could be easier to update to that new future version if JSKit at once, skipping intermediate versions. Let me know if that causes any inconvenience for you and if you'd like intermediate version such as 0.10 still be supported in some commit of DOMKit anyway

revolter commented 2 years ago

I didn't have time to continue working on my project lately 😞 But even so, I used my fork's branch in SPM, so you can safely close this PR 👍🏻

MaxDesiatov commented 2 years ago

Thank you for the PR, but we'll have to close it as outdated. DOMKit depends on the main branch of JSKit right, and we'll switch that dependency to a stable version as soon as that's released.