bug: CIFS backups resulting on faulty files (unable to decompress the backups)

swiftwave-org / swiftwave

Self-hosted lightweight PaaS solution to deploy and manage your applications on any VPS [Your own self-hosted Heroku, Vercel]

https://swiftwave.org

Apache License 2.0

313 stars 30 forks source link

bug: CIFS backups resulting on faulty files (unable to decompress the backups) #909

Open samuel-108 opened 2 days ago

samuel-108 commented 2 days ago

Describe the bug

The CIFS mounted volume's backups are resulting in faulty archives.

Are you working on this issue?

samuel-108 commented 2 days ago

The problem exist on following cases on Local mount as well

Run a filebrowser instance
While still running try to back up the filebrowser db volume
The backup comes out corrupted

samuel-108 commented 2 days ago

This only seems to occour when sqlite files are in the folder. Am unsure of any further issue beside faulty backups.

tanmoysrt commented 2 days ago

@samuel-108 thanks for reporting the issue.

Can you tryout this.

Pause (or delete for testing) the filebrowser app from dashboard
Then, create the backup

P.S: Because previously, I found that, while container is up, if we take backup of sqlite, it comes as corrupted. I haven't seen this for any SQL database(Mysql , postgres physical backup)

tanmoysrt commented 1 day ago

The logic is pretty simple behind this backup, we just run

tar -xzvf dump.tar.gz --directory <your_directoory>

to dump the volume to a file, then swiftwave manages to take it on main node (if required)

samuel-108 commented 1 day ago

I see,

It does seem to work when the container is turned off.