Customizable gradient effects

swimlane / ngx-charts

:bar_chart: Declarative Charting Framework for Angular

https://swimlane.github.io/ngx-charts/

MIT License

4.3k stars 1.15k forks source link

Open qortex opened 5 years ago

qortex commented 5 years ago

Gradients when hovering a Line-Charts (drawing below the curve) is not the same gradient as used when using Area Charts.

I would prefer to always use the line-charts effects.

This might be desired behaviour, but in this case, would it be possible to force the gradients options on components?

Screenshots Line charts gradient:

Area charts with gradients option 'on' (looks less cool in my opinion):

qortex commented 5 years ago

https://github.com/swimlane/ngx-charts/issues/1103 solves this specific example in a kind of hacky (but nice!) way.

KingDarBoja commented 5 years ago

Hello @MicMicMon,

After looking at those issues, I think a PR can be made in order to support these features and fix some bugs:

Line and Area Chart components handle persistent gradient by adding a new Input called gradientAlways.
Enable customisation of gradient opacity.
Fix #1165 for Area Chart (Probably need check Line chart too).
Fix #672, #1062 for Area Chart (Probably need check Line chart too).

Any other suggestion? @marjan-georgiev What do you think I should include on this PR?

qortex commented 5 years ago

That would be really great!

KingDarBoja commented 5 years ago

That would be really great!

Thanks, as soon as I finish fixing some PR I made, I will start on these ones.

Cheers!

Zelkreps commented 4 years ago

That would be really great!

Thanks, as soon as I finish fixing some PR I made, I will start on these ones.

Cheers!

That would be great. We also really appreciate it!

KingDarBoja commented 4 years ago

Need to get back on the track as there has been some refactor to the library itself but should be easier to work on (if I have some free time ofc).

sebastientromp commented 4 years ago

Hey! I would love to be able to customize the gradients as well. Is there any hope to get that in?

@qortex how did you manage to get the gradient in the line chart (the one that fills in the whole area) on the first screenshot?

RuneHanssens commented 4 years ago

Any update on the pr that fixes the black gradient bug? as mentioned here #1165

Deepak-Gautam commented 2 years ago

Hey! @MicMicMon, Any updates on your work regarding components handle persistent gradient?