Broken with Angular 9.1

swimlane / ngx-charts

:bar_chart: Declarative Charting Framework for Angular

https://swimlane.github.io/ngx-charts/

MIT License

4.3k stars 1.15k forks source link

Broken with Angular 9.1 #1397

Closed quedicesebas closed 4 years ago

quedicesebas commented 4 years ago

Describe the bug Broken after Angular 9.1 upgrade

Screenshots If applicable, add screenshots to help explain your problem.

Demo Provide an online demo (stackblitz, codesandbox, or similar) where the issue can be reproduced

ngx-charts version 13.0.2

StefanKoenigMUC commented 4 years ago

can confirm that.

blogcraft commented 4 years ago

Strange, it didn't happened to me.

Have you tried deleting node_modules?

linjie997 commented 4 years ago

Angular 9.1 works for me Try to delete @swimlane folder and run npm install once again

StefanKoenigMUC commented 4 years ago

indeed, helped for me.

aacebo commented 4 years ago

We updated to ng9.1 recently so this should be working now, can someone confirm?

linjie997 commented 4 years ago

This has never been broken in the first place. My guess is that ivy compiler had something dirty and it was easily fixable by deleting @swimlane folder under node_modules and run npm install once again. I have used v13.0.2 with Angular 9.1 without issues. By the way, I have now updated to v13.0.3 and it seems to be working as before.