Legend not included in height calculation

GuyT07 commented 4 years ago

Describe the bug If I omit the view property and set its container to a max-height, the legend is not included in this height (legendPosition = 'below'). Therefore, the chart can not be used in a component.

To Reproduce

Create a container and specify the height (eg. 200px)
Create a chart (eg. ngx-charts-bar-vertical-2d) with at least following properties: legendPostion = 'below' and legend = true
Check the height of the container (should be 200px)
Label is not included in the calculation

Expected behavior The label should be part of the calculation so the height of chart component is equal to the predefined height of the container.

Screenshots

ngx-charts version 14.0.0

Crocsx commented 4 years ago

Same problem here...

Because of the following bug https://github.com/swimlane/ngx-charts/issues/755 I decided to calculate a height in code, and apply it to the chart container. But now I also face this problem.

Crocsx commented 4 years ago

https://github.com/swimlane/ngx-charts/issues/1248

swimlane / ngx-charts

Legend not included in height calculation #1424